Add 'nginx_manage_repo' feature flag and defaults #420
Conversation
…Nginx repo management
There was a problem hiding this comment.
Minor nitpick, can you rename Nginx to NGINX in comments such as #420 (files)? Can you update the Changelog too?
Re Molecule tests, you could arguably create a new scenario and setup the NGINX repo beforehand in the prepare.yml playbook (you can check an example under the plus molecule tests and you can probably copy/paste the same tasks found in the role proper to setup the NGINX repository in the prepare.yml playbook). Not necessarily a requirement to merge this PR, but it would be nice.
- update CHANGELOG - s/Nginx/NGINX/g
|
@aknot242 just updated the CHANGELOG and properly named NGINX. As for the test, if we can move forward with this PR as -is that'd be great as it would unblock us, I'm under a bit of a crunch ATM but when I have the time I'll re-visit the proposed approach. Using the |
alessfg
changed the title
Proposed changes
This change adds a
nginx_manage_repoboolean which can be used to disable Nginx repo management by this role.This feature flag addresses edge-cases where Nginx' repositories are managed by other means and should not be configured by this role in order to install Nginx. The default behavior of the role is unaltered.
Checklist
defaults/main/*.yml,README.mdandCHANGELOG.md)Sidenote on Molecule tests, as a test for setting
nginx_manage_repotofalsewould effectively require current tests to be disabled, and as the default behavior is not altered, no additional tests have been added.